[WIP DONOTMERGE] Initial spike for cascading Hive Cluster Installation errors to RP #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
force-pushed
the
ARO-3525/spike-hive-provisionfailed-condition-handling
branch
2 times, most recently
from
da4b1d6
to
80ed4a4
Compare
tsatam
commented
Jul 6, 2023
schiruma
force-pushed
the
ARO-3525/spike-hive-provisionfailed-condition-handling
branch
from
97692f1
to
035e8c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Spike implementation for ARO-3525
What this PR does / why we need it:
Initial spike implementation for cascading known install failures from the installer through Hive to the RP.
This spike implements the ARM RequestDisallowedByPolicy error case.
For now, this spike implementation should not be merged as-is. The implementation is a proof-of-concept, and dependent on other moving parts (Hive deployment configuration) in order to work.
Test plan for issue:
Attempt to create a cluster against an RP running this code, pointed to a Hive cluster configured with the ARO-specific install log regex rules. This cluster should be deployed in an environment where in-installer resource provisioning (e.g. bootstrap/master node VMs) would be blocked by an Azure policy.
Is there any documentation that needs to be updated for this PR?
TBD